feat(web): add Schedules nav to the session header - #116
Merged
Merged
Conversation
Schedules were only reachable from the sessions index, so opening one from an active session meant leaving the conversation first. Put the same control next to + New (and in the session ⋯ menu) so /schedules is one click away.
Schedules copied the + New chip layout into a second 900px block. Share the compact-header layout and fold the breakpoint together. Close the session ⋯ menu before SPA navigation, matching HomeMenu, so the popover does not linger if the page ever stops unmounting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Schedules were only reachable from the sessions index. Opening
/schedulesfrom an active conversation meant going back to the list first.What
/schedules,/settings) now use SPA navigation instead of a full page load.Tests
SessionHeader.test.js— header control sits left of + New and navigates to/schedules.CommandMenu.test.js— ⋯ menu includes the schedules link and navigates.e2e/tests/schedules.spec.ts— session header button opens the schedules page.npx vitest run src/components/session/SessionHeader.test.js src/components/session/CommandMenu.test.jspasses.