DI wrapping ObjectCache for SQL object cache#20
Merged
Merged
Conversation
cliffcaseyyet
left a comment
cliffcaseyyet
left a comment
Member
There was a problem hiding this comment.
overall getting there, a few notes.
| } | ||
|
|
||
| ObjectCache(XapiConfig xapiConfig, FOMXML fomXml, HLADecoderRegistry decoderRegistry, String jdbcUrl) { | ||
| this.catalog = FomCatalog.fromFomXml(fomXml); |
Member
There was a problem hiding this comment.
Why imperatively init a singleton? Just have a FomCatalog Bean with fomXML injected into it, then wire that in here.
| private static final Logger logger = LogManager.getLogger(InjectionHandler.class); | ||
|
|
||
| private volatile CacheQueryService queryService; | ||
| private ObjectCache objectCache; |
Member
There was a problem hiding this comment.
weird that we would do constructor injection when there are already wired beans. just change to autowired and kill the 1-arg constructor OR make it a 3-arg constructor to not mix DI methodologies.
cliffcaseyyet
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps our SQL object cache in a new ObjectCache DI construct for encapsulation and lifecycle control of the cache.