ci: fix version compute on empty tag set (unblocks v0.1.0)#21
Merged
Conversation
With set -o pipefail, grep exits 1 when no tags match, which failed the whole
'latest=...' pipeline — exactly the fresh-start case (no tags) that should yield
v0.1.0. Wrap the grep in { grep ... || true; } so an empty match is benign.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After wiping all tags, the release run failed in Compute next version: under
pipefail,grep -E "$tagpat"exits 1 on no match, failing thelatest=...pipeline before it could setnext=0.1.0. Wrapped the grep in{ grep … || true; }.Verified: empty tag set →
latest=""→next=0.1.0, exit 0.Merging this triggers
release.ymlon master with no tags → it publishes the freshv0.1.0. (Same latent bug exists in the toolchain'svendor.yml, but dormant there since it always has tags — worth a follow-up patch.)