Skip to content

fix: prevent duplicate log output via propagate=False#287

Merged
spalen0 merged 1 commit into
mainfrom
fix/dedupe-logger-output
Jun 22, 2026
Merged

fix: prevent duplicate log output via propagate=False#287
spalen0 merged 1 commit into
mainfrom
fix/dedupe-logger-output

Conversation

@spalen0

@spalen0 spalen0 commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Problem

morpho.markets_v2 (and any other child logger whose parent also uses utils.logger.get_logger) prints every log line twice.

Root cause

get_logger attaches a StreamHandler to each named logger but leaves propagate = True. When a child logger (e.g. morpho.markets_v2) imports a module that creates a parent logger (e.g. morpho from protocols/morpho/markets.py), the same record is emitted by both handlers.

Fix

Set logger.propagate = False inside get_logger when we install our own handler, so each record is only emitted once.

Verification

Ran uv run protocols/morpho/markets_v2.py before and after; duplicate lines are gone.

@spalen0 spalen0 marked this pull request as ready for review June 22, 2026 15:36
@spalen0 spalen0 merged commit e1848f4 into main Jun 22, 2026
2 checks passed
@spalen0 spalen0 deleted the fix/dedupe-logger-output branch June 22, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant