Skip to content

Rollback AI slop changes and use newer dart features for cleaner code. - #214

Closed
iWisp360 wants to merge 4 commits into
yako-dev:masterfrom
iWisp360:master
Closed

iWisp360 wants to merge 4 commits into
yako-dev:masterfrom
iWisp360:master

Conversation

@iWisp360

Copy link
Copy Markdown

Connection with issue(s)

Resolve issue #213

Connected to #???

Testing and Review Notes

All tests passes

Screenshots or Videos

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • request the "UX" team perform a design review (if/when applicable)

@iWisp360
iWisp360 marked this pull request as draft September 30, 2026 05:22
@iWisp360
iWisp360 marked this pull request as ready for review September 30, 2026 05:46
@yadaniyil

Copy link
Copy Markdown
Contributor

I can't merge it: it removes all of v4 (the desktop styles, the split view, CI and the changelog) along with fixes from other contributors, and dropping DevicePlatform.fuchsia breaks existing apps.

The duplication you pointed at is being reduced in #215. Small, focused PRs on top of master are welcome.

@yadaniyil yadaniyil closed this Oct 8, 2026
@iWisp360

iWisp360 commented Oct 8, 2026

Copy link
Copy Markdown
Author

Ok btw ur reinventing the wheel, use fluent_ui and yaru for win and linux respectively.

@iWisp360

iWisp360 commented Oct 8, 2026

Copy link
Copy Markdown
Author

And ur code is too complex to maintain, I am yet to see a human maintaining your code again, your code is no longer owned by you, it's owned by Claude.

@iWisp360

iWisp360 commented Oct 8, 2026

Copy link
Copy Markdown
Author

The split view though, I love that af, and I'll implement it on a fork based on v3, which is the last maintainable point of history of this project.

@yadaniyil

Copy link
Copy Markdown
Contributor

I hope without help of AI?

@iWisp360

iWisp360 commented Oct 8, 2026

Copy link
Copy Markdown
Author

I hope without help of AI?

Ofc, a simpler implementation

@iWisp360

iWisp360 commented Oct 8, 2026 •

Copy link
Copy Markdown
Author

along with fixes from other contributors

No one contributed to your project in the last 126 commits, those commits were made by you and claude.

@yadaniyil

Copy link
Copy Markdown
Contributor

How about these?

2 by Masashi Aso, from PR 202:

  • e3ac0d3 “show value for simple tiles on iOS”
  • e33a0dd “refine iOS tile value layout”

1 by SlayerOrnstein, from PR 207:

  • 80c2c1e “lower SDK constraints”

@iWisp360

iWisp360 commented Oct 8, 2026

Copy link
Copy Markdown
Author

I rolled back up to commit d671283, meaning only the last commit u mentioned is rolled back by me, which is actually a one liner, I can just cherry-pick the commit to make u happy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants