Repository navigation
xexpression_holder generic constructor #2969
Description
xepxression_holder provides a generic non-constrained constructor. The problem is that this constructor is preferred over the copy constructor when copying non const xexpression_holder objects, leading to a segfault.
This constructor should be constrained to not accept xexpression_holder objects.
Activity
GinkelKostia commentedon Nov 11, 2026
Hi!
I would like to contribute to this issue.
I am a C++ developer with experience in modern C++, templates, CMake and unit testing. I would like to investigate the constructor overload resolution issue and work on a fix with appropriate regression tests.
Is this issue available for contribution? I would be happy to submit a pull request.
Thank you!
JohanMabille commentedon Nov 12, 2026
Hi,
Actually this issue was fixed in #2970 and I forgot to close it. But they are a lot of other issues opened if you want to contribute. Some of them have been opened for a while and may have been fixed with the different refactorings, but it might be worth giving a try to reproduce them and investigate if they're still here.
Thanks!