Move most of explore script to a module#88
Open
guillon wants to merge 4 commits into
Open
Conversation
Add support for python CLI execution with arguments for testing.
Add check-tutorials target executed by make check. Runs the scripts in scripts/tutorials.
guillon
force-pushed
the
dev/cguillon/explore-lib
branch
from
04ae191 to
9951a0c
Compare
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Fix config_file argument for random optimizer. Remove private _sample_batch method from interface. Rework classes hierarchy for better typing.
guillon
force-pushed
the
dev/cguillon/explore-lib
branch
from
9951a0c to
6d43402
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The objective is to refactor in the end most of explore script.
For now, it is mainly a move to the explore script code into the xtc.explore.Exploration class,
the point is to first move everything mostly as is, before refactoring in order to simplify merge conflicts with parallel devs.
Note that in addition, it required to change the tutorial
explore_optimizers.py, in order to enforce this, I also added tutorials tests to run it from command line.Description
Move explore script to a class and updated related code.
Commits
Discussion
Further PR will actually split Exploration class into several modules.
TODO in futher PRs: