Materialize the KirkpatrickBaez Assembly at CDI + IOS (first two fixtures)#545
Merged
Conversation
The KirkpatrickBaez blueprint shipped to the catalog with zero Fixtures. Prove it composes from real descriptor data: CDI collapses its KB pair into one KBMirror Asset, but the note names both physical mirrors with their PVs (Mir:KBv vertical, Mir:KBh horizontal). The catalog note sanctions splitting the collapsed Asset into the two mirrors that physically exist when materializing the Fixture, so bind VKB + HKB to the two Exactly1 mirror slots. Presents no Role, matching the blueprint (a KB pair focuses the beam; no catalog Role names that function). Co-Authored-By: Claude <noreply@anthropic.com>
IOS's descriptor already models the KB pair as two distinct Mirror Assets (KBMirror_Vertical / KBMirror_Horizontal, OPT-1), so the Fixture binds them directly rather than splitting a collapsed Asset as CDI does. Proves the catalog KirkpatrickBaez Assembly materializes from a descriptor that carries the mirrors pre-split, end-to-end against Postgres. Co-Authored-By: Claude <noreply@anthropic.com>
Coverage report
This PR does not seem to contain any modification to coverable code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KirkpatrickBaezAssembly (which shipped with zero Fixtures, Graduate the KirkpatrickBaez focusing-pair Assembly into the catalog #541) as its first two real bindings, both end-to-end against Postgres.KBMirrorAsset; the Fixture splits it into the physically-real VKB (Mir:KBv) + HKB (Mir:KBh) mirrors across the two Exactly1 slots, per the catalog split-on-materialize sanction.KBMirror_Vertical/KBMirror_Horizontal, OPT-1), so the Fixture binds them directly. Proves the same Assembly materializes from a pre-split descriptor.Both scenarios assert the Assembly stream (no Role, flat), the Fixture's two-slot binding, and per-Asset fixture back-references. Grounding verified against
deployments/{cdi,ios}/beamline.yaml.Test plan
test_cdi_kb_mirror_setup.pygreen against real Postgrestest_ios_kb_mirror_setup.pygreen against real Postgres