Correct the Assembly id-derivation comment in the catalog#542
Merged
Conversation
The comment claimed the spine derives each Assembly's id as uuid5 over its name, matching Family and Role. The code does not: define_assembly mints a fresh per-registration UUIDv7, and content_hash equality is what makes an Assembly recognizably the same blueprint across facilities. The stale comment misled reasoning about how Assemblies are shared, so align it with the actual behavior and call out the contrast with the name-derived Family and Role ids.
Coverage report
This PR does not seem to contain any modification to coverable code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assemblies:header comment incatalog/catalog.yamlclaimed the spine derives each Assembly's id asuuid5over its name (matching Family and Role). The running code does not:define_assemblymints a fresh per-registration UUIDv7, andcontent_hashequality is what makes an Assembly recognizably the same blueprint across facilities.Why
Surfaced during an adversarial stress-test of the Assembly/Fixture model: the stale comment had misled reasoning about how Assemblies are shared across facilities (they share by content_hash equality, not by a shared id). Comment-only change; no behavior change.
Test plan
test_catalog_descriptor+test_catalog_markersgreenmake docs-build(mkdocs --strict) greenGenerated with Claude Code