Skip to content

refactor(formula): refine the formula#136

Merged
luoliwoshang merged 3 commits into
xgo-dev:mainfrom
MeteorsLiu:feat/formula-target
Jul 9, 2026
Merged

refactor(formula): refine the formula#136
luoliwoshang merged 3 commits into
xgo-dev:mainfrom
MeteorsLiu:feat/formula-target

Conversation

@MeteorsLiu

Copy link
Copy Markdown
Collaborator

@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.17647% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/modules/target.go 78.26% 2 Missing and 3 partials ⚠️
cmd/llar/internal/test.go 66.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@MeteorsLiu MeteorsLiu requested a review from luoliwoshang July 9, 2026 08:06
@luoliwoshang

Copy link
Copy Markdown
Collaborator

modules.go那边没做defaults合并,用户输入的matrix会强制覆盖掉defaults,defaults zlib选项有值,如果用户没填,zllib选项会没有,或者需要一些合并的规则

@MeteorsLiu

Copy link
Copy Markdown
Collaborator Author

modules.go那边没做defaults合并,用户输入的matrix会强制覆盖掉defaults,defaults zlib选项有值,如果用户没填,zllib选项会没有,或者需要一些合并的规则

Done in ac1855c

@luoliwoshang luoliwoshang left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luoliwoshang luoliwoshang merged commit 0095d8d into xgo-dev:main Jul 9, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants