Revert "ci: prove a PR's tests fail without its fix (bug-fix-gate)" - #443
Merged
Conversation
Reverts #442 (merge 0aff8a2) in full, at the author's request — the unattended-merge flow it was the first piece of is no longer wanted. Removes .github/workflows/bug-fix-gate.yml and its entry in .claude/rules/release.md, and restores the two image-scan jobs to having no explicit `name:`. Note for whoever picks this up later: that last part re-introduces a real defect the reverted PR had fixed incidentally. Both image-scan workflows call their job `scan`, so both report the SAME status-check context and neither can be named in a branch protection rule. Nothing depends on that today, since main has no branch protection, but it will need fixing before any required-check rule can exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #442 (merge
0aff8a2) in full, at your request — the unattended-merge flow this was the first piece of is no longer wanted.What comes out
.github/workflows/bug-fix-gate.yml— deleted.claude/rules/release.md— removedname:Nothing depended on the gate: it was advisory, never a required check, and no branch protection rule referenced it.
One thing this revert re-introduces
The reverted PR also fixed a defect incidentally, and that fix goes away here: both image-scan workflows call their job
scanwith noname:, so both report the same status-check context and neither can be named in a branch protection rule.Harmless today —
mainhas no branch protection at all — but it will block any required-check rule you add later. Happy to re-land just that two-line naming fix on its own if you want it kept.