Repository navigation
👻 fix/WSK-00108: plugin checks forbid model API keys in workflows; watch superpowers as a companion - #1
Merged
Conversation
…tch superpowers as a companion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For wraith-skills ADR 0006 (trim to data and GCP skills) and the Claude directory hold "Uses a credential from the user's machine".
plugin_checks/test_workflows.py: the vet job must no longer have a "Machine read" step, and no workflow may reference a model API key. wraith-skills ships its repo root as the plugin, so its CI workflows count as plugin content; the key-reading steps only ever skipped (the secret was never set).sync_upstream.pyandvet_companion.py: obra/superpowers (SP) becomes a watched companion with the 13 skills ADR 0006 names, vetted against ADR 0006. mattpocock/skills stays a derived source, because companion keys are excluded from pin bumps andsetupstill derives from it.tests/test_sync_upstream.py: the clean-moved-keys fixture uses KA instead of SP, since SP is now a companion.Checks:
uv run pytest -q tests186 passed (96% coverage); ruff clean;wraith-check-pluginfrom this branch against the wraith-skills trim branch: 71 passed.