Skip to content

fix: revalidate blog 404s instead of pinning them for a year #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
josephfusco wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Draft

fix: revalidate blog 404s instead of pinning them for a year #385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/pages/blog/[slug].jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,14 @@ export async function getStaticProps(context) {
revalidate: 3_600,
});

/**
* An empty response is not proof the post is gone. A failed query returns
* the same shape, so a `notFound` without `revalidate` pins a one year
* `s-maxage` on what may be a transient upstream failure. Re-check on a
* short interval instead.
*/
if (!props?.props?.data?.post) {
return { props: {}, notFound: true };
return { notFound: true, revalidate: 300 };
}

return props;
Expand Down
Loading