Skip to content

Noir bump & Mavros interface for single binary#457

Open
veljkovranic wants to merge 6 commits into
sl/goldilocks-field-abstractionfrom
mavros_integration_single_artifact
Open

Noir bump & Mavros interface for single binary#457
veljkovranic wants to merge 6 commits into
sl/goldilocks-field-abstractionfrom
mavros_integration_single_artifact

Conversation

@veljkovranic

@veljkovranic veljkovranic commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Closes #454

Bumps Noir version so we are in line with latest Mavros. Aligned complete_passport_example utils so it compiles with the latest Noir.

Tested locally:

cargo run --release --bin provekit-cli prepare --compiler mavros ./target/basic.json --r1cs ./target/r1cs.bin --pkp ./prover.pkp --pkv ./verifier.pkv
cargo run --release --bin provekit-cli prove -p ./prover.pkp  -o ./proof.np
cargo run --release --bin provekit-cli verify -v ./verifier.pkv --proof ./proof.np
    Running `provekit-cli verify -v ./verifier.pkv --proof ./proof.np`

│ │ │ │ │ ├─╯ 90.1 μs duration, 170 MB peak memory, 9.48 kB local, 170 MB current, 28.0 allocations
│ │ │ │ ├─╯ verify: 134 μs duration, 170 MB peak memory, 26.9 kB local, 170 MB current, 43.0 allocations
│ │ │ │ ├─╮ whir::protocols::sumcheck::verify start: 170 MB current, 89.3k allocations
│ │ │ │ ├─╯ 1.96 μs duration, 170 MB peak memory, 280 B local, 170 MB current, 5.00 allocations
│ │ │ ├─╯ whir::verify: 3.65 ms duration, 172 MB peak memory, 1.77 MB local, 170 MB current, 502 allocations
│ │ ├─╯ whir_zk::verify: 98.7 ms duration, 242 MB peak memory, 72.3 MB local, 170 MB current, 44.3k allocations
│ ├─╯ verify: 307 ms duration, 243 MB peak memory, 208 MB local, 34.8 MB current, 88.7k allocations
├─╯ verify: 308 ms duration, 243 MB peak memory, 208 MB local, 34.8 MB current, 88.8k allocations
╯ run: 348 ms duration, 243 MB peak memory, 243 MB local, 166 kB current, 89.3k allocations

@vercel

vercel Bot commented Jun 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs-provekit-org Ready Ready Preview Jul 2, 2026 11:08am

Request Review

@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

CSP benchmarks

Metric Value
Workflow status [PASS] success
Commit 2fc78744e3c5
Run #28585438644
Circuits benchmarked 21
Iterations averaged per circuit 3

Prover time, peak RSS, peak heap, and verifier time are arithmetic means across the iterations. Peak heap comes from the largest peak memory entry in provekit-cli prove's tracing output; peak RSS is reported by /usr/bin/time -v (max-resident-set-size).

No baseline available yet — deltas will appear once this workflow has produced at least one successful main run.

Results
Circuit Constraints Witnesses Prover time Peak RSS Peak heap Verifier time Proof size PKP size
ecdsa_p256 143,321 258,215 2.64 s 258 MB 225 MB 340 ms 2.80 MB 811 KB
keccak_1024 788,814 1,490,812 6.33 s 974 MB 939 MB 827 ms 3.17 MB 5.88 MB
keccak_128 157,522 304,529 2.12 s 271 MB 240 MB 363 ms 2.77 MB 1.26 MB
keccak_2048 1,507,374 2,840,532 11.68 s 1.78 GB 1.77 GB 1.42 s 3.28 MB 11.97 MB
keccak_256 247,782 474,010 2.33 s 326 MB 286 MB 410 ms 2.84 MB 1.88 MB
keccak_512 428,126 812,944 3.61 s 581 MB 502 MB 550 ms 3.00 MB 3.32 MB
poseidon2_12 479 563 350 ms 24.55 MB 14.69 MB 100 ms 1.04 MB 437 KB
poseidon2_16 556 719 350 ms 24.79 MB 14.88 MB 100 ms 1.05 MB 530 KB
poseidon2_2 231 278 340 ms 23.63 MB 14.11 MB 100 ms 1.05 MB 108 KB
poseidon2_4 529 535 340 ms 24.03 MB 14.31 MB 100 ms 1.05 MB 31.67 KB
poseidon2_8 363 423 350 ms 24.83 MB 14.50 MB 100 ms 1.04 MB 365 KB
poseidon_12 504 524 350 ms 24.98 MB 14.88 MB 100 ms 1.04 MB 569 KB
poseidon_16 609 633 353 ms 25.11 MB 15.16 MB 103 ms 1.01 MB 717 KB
poseidon_2 240 249 340 ms 23.64 MB 14.02 MB 100 ms 1.04 MB 59.19 KB
poseidon_4 297 309 347 ms 24.24 MB 14.50 MB 100 ms 1.05 MB 332 KB
poseidon_8 402 418 347 ms 24.52 MB 14.69 MB 100 ms 1.04 MB 448 KB
sha256_1024 196,940 339,764 2.22 s 305 MB 274 MB 420 ms 2.81 MB 1.86 MB
sha256_128 46,398 80,974 1.09 s 101 MB 83.54 MB 260 ms 2.49 MB 508 KB
sha256_2048 345,399 612,724 3.60 s 548 MB 483 MB 597 ms 2.98 MB 3.15 MB
sha256_256 67,904 117,944 1.38 s 150 MB 130 MB 290 ms 2.62 MB 731 KB
sha256_512 110,916 191,884 1.51 s 180 MB 158 MB 320 ms 2.67 MB 1.11 MB

@veljkovranic veljkovranic force-pushed the mavros_integration_single_artifact branch from db209fa to a126fd5 Compare July 2, 2026 11:08
@veljkovranic veljkovranic changed the base branch from main to sl/goldilocks-field-abstraction July 2, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adapt to Mavros output being a single binary

1 participant