Skip to content

fix(renovate): explicitly enable minor and patch updates#663

Open
willporter-workos wants to merge 1 commit into
mainfrom
fix/renovate-enable-minor-patch
Open

fix(renovate): explicitly enable minor and patch updates#663
willporter-workos wants to merge 1 commit into
mainfrom
fix/renovate-enable-minor-patch

Conversation

@willporter-workos
Copy link
Copy Markdown
Contributor

Summary

The shared workos/renovate-config preset now explicitly disables major and minor updates for non-github-actions managers to enforce a patch-only policy on the monorepo.

Renovate applies packageRules in order — preset rules first, then repo rules on top. Because the shared preset sets enabled: false for minor updates, and this repo's rule sets automerge: true but not enabled: true, minor updates would silently stop getting PRs.

Fix

Add "enabled": true to the existing minor/patch rule so it explicitly re-enables minor updates after the shared preset disables them.

🤖 Generated with Claude Code

The shared preset now disables minor updates by default. Add enabled: true
to the minor/patch rule so this repo continues to receive minor PRs.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@willporter-workos willporter-workos requested review from a team as code owners May 26, 2026 20:00
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 26, 2026

Greptile Summary

This PR fixes a Renovate configuration regression caused by the shared workos/renovate-config preset now explicitly disabling minor updates for non-github-actions managers. Adding "enabled": true to the repo-level minor/patch rule ensures it overrides the preset and continues generating auto-merged PRs.

  • Adds "enabled": true to the minor/patch packageRule so the shared preset's enabled: false is overridden at the repo level.
  • The major update rule (automerge: false) has no corresponding "enabled": true, which may mean major-version PRs are also being silently suppressed if the preset disables them too — this may be intentional but is worth confirming.

Confidence Score: 4/5

Safe to merge; the one-line addition correctly re-enables minor/patch update PRs.

The fix itself is correct and well-reasoned. A minor open question remains about whether the major update rule also needs enabled: true to keep generating major-version PRs, since the same shared preset reportedly disables those too.

renovate.json — specifically the major update rule, to confirm whether suppressing major-version PRs is intentional.

Important Files Changed

Filename Overview
renovate.json Adds "enabled": true to the minor/patch packageRule to explicitly re-enable those update types after the shared preset disables them; the major rule has no corresponding enabled: true which may suppress major-update PRs silently.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Renovate Config Resolution] --> B[Load shared preset
github>workos/renovate-config]
    B --> C{Update Type}
    C -->|minor/patch
non-github-actions| D[Preset: enabled=false]
    C -->|major
non-github-actions| E[Preset: enabled=false]
    C -->|github-actions| F[Preset: not affected]
    D --> G[Repo rule: enabled=true
automerge=true FIXED]
    E --> H[Repo rule: automerge=false
no enabled=true - No PRs?]
    F --> I[Repo rules applied normally]
    G --> J[Minor/patch PRs created
and auto-merged]
    H --> K[Major updates silently suppressed]
    I --> L[GitHub Actions PRs created]
Loading

Comments Outside Diff (1)

  1. renovate.json, line 22-27 (link)

    P2 If the shared preset now disables both major and minor updates for non-github-actions managers (as the PR description states), the major rule below also lacks "enabled": true. Without it, major updates would be silently suppressed entirely — no PRs created at all — rather than the apparent intent of creating PRs but not auto-merging them. Worth verifying whether that's deliberate for this repo or an oversight similar to the one being fixed here.

Reviews (1): Last reviewed commit: "fix(renovate): explicitly enable minor a..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants