Repository navigation
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1698.
verifyHeaderonly rejected timestamps that were too old, so a future-dated header passed. It now compares the absolute difference against the tolerance, and rejects at=value that isn't a plain integer (before,parseIntreturnedNaNfor junk and every comparison with it was false).The WorkOS docs say the timestamp is milliseconds since the epoch (https://workos.com/docs/webhooks), which is what the check compares. Three spec fixtures built their timestamp as
Date.now() * 1000, microseconds, so I changed them toDate.now()to match the docs.Added tests for malformed values and for offsets just inside and just outside the tolerance. Ran the full suite on Node 22 and 24 locally.