Repository navigation
ci: pass major.minor Ruby version to setup-ruby - #220
Merged
Merged
Conversation
setup-ruby embeds its known-version table in each release, so an exact .ruby-version patch newer than the pinned action fails with "Unknown version" before generation runs. This has broken sdk_build (ruby) twice (3.4.10 on 2026-09-17, 3.4.11 on 2026-10-15), each time right after workos-ruby's Renovate adopted a new Ruby patch. setup-ruby resolves a major.minor prefix to the newest stable patch it knows, so a Ruby patch bump in workos-ruby can no longer break this job.
Contributor
 [Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryThe PR passes Ruby’s major.minor version from
Reviews (1) · Last reviewed commit: "ci: pass major.minor Ruby version to set..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to #219.
sdk_build (ruby)has broken twice on the same pattern (3.4.10 on 2026-09-17, 3.4.11 on 2026-10-15): workos-ruby's Renovate adopts a new Ruby patch, and our SHA-pinnedruby/setup-rubydoesn't know it yet because setup-ruby bakes its known-version table into each release. The job dies withUnknown version X for ruby on ubuntu-24.04before any generation runs.Only Ruby has this failure mode.
setup-pythonandsetup-gofetch their version manifests at runtime.What
Feed setup-ruby
major.minor(e.g.3.4) from.ruby-versioninstead of the exact patch. setup-ruby'svalidateRubyEngineAndVersionfalls back to the newest stable version that starts with the given prefix, so the job always gets a known 3.4.x. A patch of drift from workos-ruby's own CI is irrelevant for codegen validation.Note: the
sdk_buildmatrix skips on CI-only changes (path filter), so this isn't exercised by this PR's own checks. The shell expression was checked locally (3.4.11→3.4).