Repository navigation
Conversation
Collaborator
Author
|
On hold until the upstream sync for workoho/hostwarden-workspace#29 is merged. The fork's An AI agent wrote this text in my name, on my instructions. |
Run ghcr.io/browserless/chromium pinned to v2.57.3 instead of the v1 image browserless/chrome. v2 refuses connections without a token, so the service takes TOKEN from BROWSERLESS_TOKEN and rsshub passes it in PLAYWRIGHT_CDP_ENDPOINT, the variable the synced code reads. The healthcheck sends the token too. The real-browser service and PUPPETEER_REAL_BROWSER_SERVICE go away, since the synced code no longer reads it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Gl4dr3x
force-pushed
the
claude/i-27-browserless-v2
branch
from
October 26, 2026 23:38
efbdd11 to
abd98fa
Compare
Gl4dr3x
changed the title
Gl4dr3x
changed the base branch from
master
to
claude/i-70-compose-hardening-ea3cfd
October 26, 2026 23:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gap: The
browserlessservice runsbrowserless/chrome, Browserless v1 on Docker Hub, built in February 2024. The synced code (#78) connects to it differently, andreal-browseris no longer read.Change:
browserlessusesghcr.io/browserless/chromium:v2.57.3, withTOKENfrom the Coolify variableBROWSERLESS_TOKEN(:?, so a deploy is blocked while it is empty).rsshubgetsPLAYWRIGHT_CDP_ENDPOINT: ws://browserless:3000?token=…from the same variable, replacingPUPPETEER_WS_ENDPOINT. The/pressurehealthcheck sends the token.PUPPETEER_REAL_BROWSER_SERVICEand thereal-browserservice are removed. Endpoint format, token wiring and healthcheck are copied from upstream'sdocker-compose.ymlas it stands on the #78 branch.Order: This PR works only together with or after #78, which adds
PLAYWRIGHT_CDP_ENDPOINThandling; the base is the branch of #76, because removingreal-browserreplaces #76'sexposechange for that service. Before #78, the old code readsPUPPETEER_WS_ENDPOINTonly and gets no browser.Before merge, in Coolify:
BROWSERLESS_TOKENto a new random value.browserlessis healthy.@/utils/playwright, among them/bilibili/ranking/all,/apkpure/versions/jp.co.craftegg.band/jpand/chinatimes/realtimenews. The fork's own routes use no browser. Each should return items, not an error.Rollback is a revert and a redeploy.
Unverified:
${BROWSERLESS_TOKEN:?}under Coolify (docs only), and thev2.57.3tag (taken from the GHCR listing, not run). Upstream's own default value for the token is replaced by:?. Nothing was run on a Docker host.Verified: pre-commit hook run with lint-staged (it skips
*.yml, so it changed nothing in this file);oxfmt --checkclean on the file.Refs workoho/hostwarden-workspace#27. Not closed until the test routes pass.
🤖 Generated with Claude Code