Skip to content

fix: deprecate nonpositive batch sizes before 5.0 - #64

Open
tongwentao wants to merge 4 commits into
wolph:developfrom
tongwentao:fix/positive-batch-size
Open

tongwentao wants to merge 4 commits into
wolph:developfrom
tongwentao:fix/positive-batch-size

Conversation

@tongwentao

Copy link
Copy Markdown

This replaces closed PR #62 with the compatibility changes requested in the maintainer's review. GitHub does not allow the contributor account to reopen #62.

Sizes below 1 have been accepted since batcher was introduced. Rejecting them immediately would break existing 4.x callers, including batcher([], 0) and sizes computed from a small input. This revision follows the maintainer's compatibility plan: warn in 4.x and reserve ValueError for 5.0.

  • batcher emits one DeprecationWarning for a size below 1 when iteration begins, before consuming the source. Its existing result is preserved: one batch containing all items, or no batches for an empty source.
  • Without an interval, abatcher emits the same warning and preserves existing behavior, including the assertion for size 0 and the single final batch for a negative size.
  • With an interval, abatcher accepts None, 0 and negative sizes as no size limit, without warning. Interval deadlines and cancellation behavior remain covered by the existing tests, now also exercised with 0 and -1.
  • Warnings point to the caller. Callers who turn deprecations into errors fail before any source items are consumed or scheduled. Positive sizes retain lazy, bounded consumption and issue no warning.

Both docstrings and the changelog explain the staged deprecation. This PR does not implement the future 5.0 exception.

Validation on Python 3.13.5, using the existing development environment over SSH on Linux:

  • Full tests and doctests: 405 passed, 100% statement and branch coverage.
  • Batching module: 51 passed, covering empty/nonempty sources, warning timing/category/location, warnings promoted to errors, positive sizes, and interval-only behavior and deadlines.
  • Ruff lint and format, Mypy, basedpyright, Pyrefly and Codespell passed.
  • Sphinx HTML build with warnings treated as errors passed.

Other interpreter versions are left to CI. This revision was prepared and validated with Codex.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant