asn.c: guard empty otherName copy to avoid NULL memcpy (UBSan) - #11117
Open
night1rider wants to merge 1 commit into
Open
asn.c: guard empty otherName copy to avoid NULL memcpy (UBSan)#11117night1rider wants to merge 1 commit into
night1rider wants to merge 1 commit into
Conversation
When a subjectAltName otherName has an empty value, SetDNSEntry() called XMEMCPY(dst, NULL, 0). Passing NULL to memcpy is undefined behavior and aborts under UBSan. Skip the copy unless there is real data to copy.
|
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11117
Scan targets checked: wolfcrypt-bugs, wolfcrypt-src
No new issues found in the changed files. ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a subjectAltName otherName has an empty value, SetDNSEntry() called XMEMCPY(dst, NULL, 0). Passing NULL to memcpy is undefined behavior and aborts under UBSan. Skip the copy unless there is real data to copy.