-
Notifications
You must be signed in to change notification settings - Fork 30
Add typing: asn, exceptions, hashes, pwdbased, utils. #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
roberthdevries
wants to merge
7
commits into
wolfSSL:master
Choose a base branch
from
roberthdevries:add-more-typing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
de901ee
Add typing: asn, exceptions, hashes, hkdf, pwdbased, utils.
roberthdevries 8814d7f
Add typing information to ciphers.py
roberthdevries 1af1a55
Address review comments and annotate overrides.
roberthdevries 4545d59
Address more review comments.
roberthdevries b6cc32e
Add py.typed file to indicate that this library has typing annotations.
roberthdevries e00c5d5
Addressed more review comments.
roberthdevries 0ad1356
Address more review comments.
roberthdevries File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 [Medium] typing-extensions dependency has no minimum version (override requires =4.4.0)
The PR adds
from typing_extensions import overrideas an unconditional runtime import inwolfcrypt/ciphers.pyandwolfcrypt/hashes.py.overridewas only added totyping_extensionsin 4.4.0 (andtyping.overridedoes not exist until Python 3.12, while this package now supports 3.10/3.11 perrequires-python = ">=3.10"). The new dependency is declared as just"typing-extensions"with no version floor. On an environment that already has an oldertyping_extensionsinstalled, pip will treat the unconstrained requirement as already satisfied and not upgrade it, sofrom typing_extensions import overrideraisesImportErrorand the entirewolfcryptpackage fails to import.Fix: Pin a minimum version (
typing-extensions>=4.4.0) sooverrideis guaranteed to be importable on all supported Python versions.