Pin M33MU to upstream master with deterministic USART timing - #55
Merged
Merged
Conversation
aidangarske
commented
Oct 1, 2026
Member
- Bump M33MU_REF to f3c03675 (danielinux/m33mu master with # 21) in the M33MU workflow, the STM32H563 runner and the MIMXRT700 runner.
- m33mu # 21 raises the STM32 USART interrupt at the register write instead of the next host poll, and makes --uart-stdout lossless and ordered under a slow host. This removes the per-run interrupt-timing drift behind the occasional confboot test 66 failure and the lost console lines on CI.
- Should close M33MU runs occasionally lose console output or shift interrupt timing on GitHub runners #34
aidangarske
requested review from
mattia-moffa
and
a balanced review from Copilot
October 1, 2026 16:14
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Both runners can silently reuse cached binaries built from an older M33MU revision.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Pins M33MU to the upstream revision containing deterministic USART timing and lossless console output, while removing the now-upstreamed RT700 patch.
Changes:
- Updates M33MU references across CI and target runners.
- Removes the RT700 emulator patch.
- Updates testing documentation for unpatched upstream M33MU.
| File | Description |
|---|---|
.github/workflows/m33mu.yml |
Pins CI to the new revision. |
tests/target/run_m33mu_scenario.sh |
Updates the STM32H563 runner pin. |
tests/target/run_rt700_m33mu.sh |
Updates the RT700 pin and removes patch application. |
tests/target/m33mu-imxrt700.patch |
Deletes the upstreamed patch. |
docs/Testing.md |
Documents using unpatched upstream M33MU. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mattia-moffa
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
