Validate runner scenario names against the scenario matrix - #54
Merged
mattia-moffa merged 1 commit intoOct 1, 2026
Merged
Conversation
aidangarske
commented
Oct 1, 2026
aidangarske
commented
Member
- Every PR that added an M33MU scenario edited the same long usage line at the top of run_m33mu_scenario.sh and run_rt700_m33mu.sh, so concurrent PRs conflicted on every rebase. This reduces that risk
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Both runners correctly consume their full-tier scenario lists without changing accepted scenarios.
Review effort: Balanced
Findings: None
What changed in this PR
Centralizes M33MU scenario validation to reduce merge conflicts.
Changes:
- Derives valid scenarios from
scenario_matrix.py. - Generates usage text dynamically.
| File | Description |
|---|---|
tests/target/run_rt700_m33mu.sh |
Validates RT700 scenarios against the matrix. |
tests/target/run_m33mu_scenario.sh |
Validates STM32H563 scenarios against the matrix. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
aidangarske
force-pushed
the
ci/scenario-list-from-matrix
branch
from
October 1, 2026 16:11
5c9d2bc to
d5f2c03
Compare
aidangarske
added
the
ci:all
mattia-moffa
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.