Restore upstream wolfHSM pin and release updates - #53
Merged
Merged
Conversation
aidangarske
commented
Oct 1, 2026
aidangarske
commented
Member
- wolfHSM still pointed to a fork after Support 128-bit flash programming units wolfHSM#524 merged.
- Restore the upstream URL and pin main at 66e2482.
- Require the merged flash support before automatic release bumps.
- Complete COMM INIT before guest crypto requests.
- Clean up failed handshakes and cover recovery with regression tests.
- make test and four firmware builds passed.
- M33MU positive passed with both engines; hsmattackneg passed with hsm.
- Closes lib/wolfHSM wolfHSM-v1.5.0 breaks wolfTrust #7.
aidangarske
added
the
ci:all
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
A failed handshake during callback-based retry unregisters the retry callback, preventing subsequent automatic recovery.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Restores upstream wolfHSM integration and adds the required COMM INIT handshake with failure cleanup.
Changes:
- Restores the upstream wolfHSM URL and release gate.
- Performs
COMM INITbefore guest crypto operations. - Adds recovery tests and documentation.
| File | Description |
|---|---|
.gitmodules |
Restores upstream wolfHSM URL. |
.github/workflows/auto-pin-dependencies.yml |
Gates release bumps on PR #524. |
wolfhsm_client_glue.c |
Adds handshake and cleanup. |
tests/host/wolfhsm_relay/main.c |
Tests handshake failure recovery. |
docs/Crypto-Engines.md |
Documents initialization behavior. |
docs/Building.md |
Documents pin requirements. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
aidangarske
force-pushed
the
fix/wolfhsm-upstream-pin
branch
from
October 1, 2026 16:15
3c9cf17 to
c279a2b
Compare
mattia-moffa
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.