Repository navigation
Enable single label host names - #59
Open
padelsbach wants to merge 1 commit into
Open
padelsbach wants to merge 1 commit into
padelsbach wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the change enabling single-label hostnames in the Mbed TLS compatibility layer.
No open issues 🎉
What changed in this PR
Enables single-label hostnames such as router in the Mbed TLS compatibility layer by configuring wolfSSL to accept them.
Changes:
- Enables wolfSSL’s single-label hostname option.
- Adds certificate-verification tests for matching, case-insensitive, and mismatched single-label names.
- Updates documentation and the rejected-hostname test to reflect the remaining DNS-name restrictions.
| File | Description |
|---|---|
user_settings.h |
Enables single-label hostnames for Mbed TLS compatibility. |
test/mbedtls_compat/ssl_test.c |
Adds a certificate fixture and hostname-verification tests; updates the rejected-name case. |
README.md |
Replaces the single-label limitation with the remaining hostname restrictions. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow host names without a dot. WolfSSL already has a special case for
localhost.