Repository navigation
Add TF-PSA-Crypto public key parsing and mbedtls_pk_get_bitlen - #57
Open
padelsbach wants to merge 1 commit into
Open
padelsbach wants to merge 1 commit into
padelsbach wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The EC public-key policy incorrectly matches hashless ECDSA against the ANY_HASH wildcard, reporting VERIFY_HASH support for an algorithm outside the advertised policy.
1 open issue
What changed in this PR
Extends wolfPSA’s TF-PSA-Crypto compatibility layer with public-key parsing and key bit-length reporting.
Changes:
- Adds public-key parsing from PEM/DER buffers and files for RSA, EC, X25519, and X448.
- Tracks key sizes and expands capability checks for public-key operations.
- Adds compatibility tests and documents supported formats and limitations.
| File | Description |
|---|---|
wolfpsa/mbedtls/pk.h |
Adds public-key storage, key size, and API declarations. |
test/mbedtls_compat/pk_test.c |
Tests public-key parsing, bit lengths, capabilities, and invalid inputs. |
src/psa_tf_psa.c |
Implements parsing, size reporting, cleanup, and capability policies. |
README.md |
Documents the expanded key-parsing support. |
.gitignore |
Ignores root build-* directories except build-test. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds mbedtls_pk_parse_public_key, mbedtls_pk_parse_public_keyfile and mbedtls_pk_get_bitlen to the TF-PSA-Crypto pk.h API.