Engine cleanup and hardening #226

Open

aidangarske wants to merge 42 commits into

wolfSSL:masterfrom

aidangarske:fenrir-findings-fixes

Commits on Jun 17, 2026

Fix wrong variable in NULL check after EVP_CIPHER_meth_new for AES-CBC-HMAC
aidangarske
committed
Validate record length in AES-CBC-HMAC TLS decrypt to prevent underflow
aidangarske
committed
Handle NULL output length query in RSA private decrypt
aidangarske
committed
Use correct element size when copying RSA NID list into digest method
aidangarske
committed
Correct inverted NULL check on cipher data in we_aes_cbc_ctrl
aidangarske
committed
Correct inverted NULL check on cipher data in we_aes_ecb_ctrl
aidangarske
committed
Correct inverted NULL check on cipher data in we_des3_cbc_ctrl
aidangarske
committed
Initialize AES-ECB key alongside wc_AesInit when key is provided
aidangarske
committed
Reject unknown digest names in TLS1-PRF and HKDF ctrl_str handlers
aidangarske
committed
Initialize ECDSA signature mp_ints once in direct sign path
aidangarske
committed
Free DH generator buffer on all paths in key generation
aidangarske
committed
Clamp GCM IV increment loop to avoid out-of-bounds write for short IVs
aidangarske
committed
Propagate EVP_CIPHER_asn1_to_param failure in PBES2 key generation
aidangarske
committed
Return 0 not -1 from AES-CTR init on IV-set failure
aidangarske
committed
Use AES block size for AES-CTR block counter modulus
aidangarske
committed
Log salt pointer not key in HKDF salt allocation failure
aidangarske
committed
Advance buffer index by two after debug separator in hex dump
aidangarske
committed
Fix mismatched endif comment in we_random.c
aidangarske
committed
Match RNG cleanup condition to RNG init condition
aidangarske
committed
Only store RSA-PSS salt length when padding mode is PSS
aidangarske
committed
Free buffered GCM input before reallocating on repeated update
aidangarske
committed
Zeroize buffered GCM plaintext when freeing in final and cleanup
aidangarske
committed
Use clear_realloc to wipe relocated HMAC key padding buffer
aidangarske
committed
Free ASN1 key when EVP_PKEY_assign fails in HMAC keygen
aidangarske
committed
Free DH object when EVP_PKEY_assign_DH fails in paramgen
aidangarske
committed
Free DH object when EVP_PKEY_assign_DH fails in keygen
aidangarske
committed
Free RSA object when EVP_PKEY_assign_RSA fails in keygen
aidangarske
committed
Zeroize HKDF salt buffer on context cleanup
aidangarske
committed
Cleanse derived key and IV stack buffers in PBE key generation
aidangarske
committed
Zeroize private key BIGNUMs in EC_KEY_oct2priv and DH_set0_key backports
aidangarske
committed
Reject GCM IV generation longer than the IV buffer
aidangarske
committed
Accept zero-length CMAC update to match OpenSSL and HMAC behavior
aidangarske
committed
Bound HMAC ASN1 private key length before narrowing to int
aidangarske
committed
Bound ECDSA signature SEQUENCE length parse to signature buffer
aidangarske
committed
Pad HMAC key via portable malloc and clear_free instead of clear_realloc
aidangarske
committed
Size debug hex-dump line buffer for the two-byte separator
aidangarske
committed
Swap GCM buffer only after successful allocation in update
aidangarske
committed
Allow empty HMAC raw private key import while bounding length
aidangarske
committed
Skip stitched AES-CBC-HMAC and RSA no-padding query tests under FIPS
aidangarske
committed
Guard remaining new negative tests under FIPS builds
aidangarske
committed
test: skip AES-CBC-HMAC-SHA256 short-record test when stitched cipher absent
aidangarske
committed

Commits on Jun 18, 2026

Revert "Allow empty HMAC raw private key import while bounding length" because its test_hmac_empty_raw_key crashes the Non FIPSv2 CI job with a double free on OpenSSL 1.1.1b.
aidangarske
committed