Repository navigation
Add the bundled System V IPC extensions - #268
Merged
Merged
Conversation
Enable sysvsem, sysvshm, and sysvmsg in the PHP 8 images. They ship with PHP and need no extra libraries. Production images remove the PHP sources and build tools, so they cannot be added downstream. Nextcloud uses sysvsem to limit concurrent preview generation and warns when it is missing. Debian and Ubuntu PHP packages enable all three by default. Add them to the expected module lists and add functional checks for a message round trip, an exclusive semaphore, and shared memory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Nextcloud running on these images warns that the
sysvsemPHP module is missing. Without it, Nextcloud cannot limit how many image previews it generates at the same time, so a burst of preview requests can use far more CPU and memory than intended. Users cannot add the module themselves.Cause
The module ships with PHP itself, but the images never turned it on. Production images remove the PHP source code and build tools at the end of the build, so a derived image has nothing to compile it from.
Solution
The PHP 8 images now include
sysvsemalong with its two companion modules,sysvshm(shared memory) andsysvmsg(message queues). These let PHP processes in the same container coordinate with each other. Debian and Ubuntu PHP packages enable all three by default, so applications tested there will find them here too. They need no extra system libraries and add about 200 KB to the image. Nothing changes for applications that don't use them.Closes #267
Changes
8/Dockerfile: addsysvmsg,sysvsem, andsysvshmto the bundleddocker-php-ext-installlist for PHP 8.2–8.5.8/tests/php_modules/*: expect the three modules.8/tests/functional/local.php: functional checks for a message queue round trip, a single-holder semaphore that refuses a second holder, and a shared memory write and read.README.md,8/tests/README.md: list the modules and the new checks.Validation
8.5production (arm64) locally.php -mlists all three modules, and each.sois 66 KB after stripping.make testagainst that image passed, including the module list comparison and the newsysvmsg,sysvsem, andsysvshmfunctional checks.Follow-up
A new image revision tag is needed after merge to publish the change.