Skip to content

fix: Dialog - prevent open animation interruption by residual touch on Android #4037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Yoavpagir wants to merge 1 commit into from
Closed

fix: Dialog - prevent open animation interruption by residual touch on Android #4037

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/react-native-ui-lib/src/components/dialog/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,12 @@ const Dialog = (props: DialogProps, ref: ForwardedRef<DialogImperativeMethods>)
};

const panGesture = Gesture.Pan()
// MOBAPP-2994: require a deliberate drag before the pan engages. Without this, on Android/Fabric
// the residual touch stream from a gesture-handler trigger (e.g. List.Item's TapGestureHandler,
// which fires onPress on END while the touch is still settling) leaks into this freshly-mounted
// pan and drives `visibility` mid-open, interrupting the open spring so the sheet rests part-way.
// A plain touchable trigger (Button) lifts cleanly before the modal mounts and is unaffected.
.minDistance(10)
.onStart(event => {
initialTranslation.value =
getTranslationReverseInterpolation(isVertical ? event.translationY : event.translationX) - visibility.value;
Expand Down
Loading