Skip to content

fix: replace url-parse with native URL API #4033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adids1221 merged 1 commit into from
Jul 19, 2026
Merged

fix: replace url-parse with native URL API #4033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
"@types/react": "19.0.0",
"@types/react-test-renderer": "^19.0.0",
"@types/tinycolor2": "^1.4.2",
"@types/url-parse": "^1.4.3",
"@typescript-eslint/eslint-plugin": "^5.62.0",
"@typescript-eslint/parser": "^5.62.0",
"@welldone-software/why-did-you-render": "^3.2.1",
Expand Down
2 changes: 0 additions & 2 deletions packages/react-native-ui-lib/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
"react-native-redash": "^12.0.3",
"semver": "^5.5.0",
"tinycolor2": "^1.4.2",
"url-parse": "^1.2.0",
"wix-react-native-text-size": "1.0.9"
},
"devDependencies": {
Expand Down Expand Up @@ -71,7 +70,6 @@
"@types/react": "19.0.0",
"@types/react-test-renderer": "19.0.0",
"@types/tinycolor2": "^1.4.2",
"@types/url-parse": "^1.4.3",
"@welldone-software/why-did-you-render": "^3.2.1",
"babel-plugin-lodash": "^3.3.4",
"babel-plugin-module-resolver": "^5.0.0",
Expand Down
9 changes: 3 additions & 6 deletions packages/react-native-ui-lib/src/helpers/AvatarHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import _ from 'lodash';
import URL from 'url-parse';
import Colors from '../style/colors';
import {Typography} from 'style';

Expand Down Expand Up @@ -100,10 +99,8 @@ export function isBlankGravatarUrl(url: string) {
}

export function patchGravatarUrl(gravatarUrl: string) {
const url = new URL(gravatarUrl, true);
const {query} = url;
query.d = '404';
delete query.default;
url.set('query', query);
const url = new URL(gravatarUrl);
url.searchParams.set('d', '404');
url.searchParams.delete('default');
return url.toString();
}
34 changes: 0 additions & 34 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3088,13 +3088,6 @@ __metadata:
languageName: node
linkType: hard

"@types/url-parse@npm:^1.4.3":
version: 1.4.11
resolution: "@types/url-parse@npm:1.4.11"
checksum: 10c0/24a470a28393871c83e94006a80f6fb2e7c6dd9c0b031ee575fe792291cf28aec1f0523512b77a09190a4918158e7c68c03c04b8aa97e76b0153aec52f767bd6
languageName: node
linkType: hard

"@types/yargs-parser@npm:*":
version: 21.0.3
resolution: "@types/yargs-parser@npm:21.0.3"
Expand Down Expand Up @@ -9351,13 +9344,6 @@ __metadata:
languageName: node
linkType: hard

"querystringify@npm:^2.1.1":
version: 2.2.0
resolution: "querystringify@npm:2.2.0"
checksum: 10c0/3258bc3dbdf322ff2663619afe5947c7926a6ef5fb78ad7d384602974c467fadfc8272af44f5eb8cddd0d011aae8fabf3a929a8eee4b86edcc0a21e6bd10f9aa
languageName: node
linkType: hard

"queue-microtask@npm:^1.2.2":
version: 1.2.3
resolution: "queue-microtask@npm:1.2.3"
Expand Down Expand Up @@ -9659,7 +9645,6 @@ __metadata:
"@types/react": "npm:19.0.0"
"@types/react-test-renderer": "npm:^19.0.0"
"@types/tinycolor2": "npm:^1.4.2"
"@types/url-parse": "npm:^1.4.3"
"@typescript-eslint/eslint-plugin": "npm:^5.62.0"
"@typescript-eslint/parser": "npm:^5.62.0"
"@welldone-software/why-did-you-render": "npm:^3.2.1"
Expand Down Expand Up @@ -9710,7 +9695,6 @@ __metadata:
"@types/react": "npm:19.0.0"
"@types/react-test-renderer": "npm:19.0.0"
"@types/tinycolor2": "npm:^1.4.2"
"@types/url-parse": "npm:^1.4.3"
"@welldone-software/why-did-you-render": "npm:^3.2.1"
babel-plugin-lodash: "npm:^3.3.4"
babel-plugin-module-resolver: "npm:^5.0.0"
Expand Down Expand Up @@ -9753,7 +9737,6 @@ __metadata:
tinycolor2: "npm:^1.4.2"
typescript: "npm:5.0.4"
uilib-native: "workspace:*"
url-parse: "npm:^1.2.0"
wix-react-native-text-size: "npm:1.0.9"
peerDependencies:
react: ">=19.0.0"
Expand Down Expand Up @@ -10077,13 +10060,6 @@ __metadata:
languageName: node
linkType: hard

"requires-port@npm:^1.0.0":
version: 1.0.0
resolution: "requires-port@npm:1.0.0"
checksum: 10c0/b2bfdd09db16c082c4326e573a82c0771daaf7b53b9ce8ad60ea46aa6e30aaf475fe9b164800b89f93b748d2c234d8abff945d2551ba47bf5698e04cd7713267
languageName: node
linkType: hard

"reselect@npm:^4.1.7":
version: 4.1.8
resolution: "reselect@npm:4.1.8"
Expand Down Expand Up @@ -11421,16 +11397,6 @@ __metadata:
languageName: node
linkType: hard

"url-parse@npm:^1.2.0":
version: 1.5.10
resolution: "url-parse@npm:1.5.10"
dependencies:
querystringify: "npm:^2.1.1"
requires-port: "npm:^1.0.0"
checksum: 10c0/bd5aa9389f896974beb851c112f63b466505a04b4807cea2e5a3b7092f6fbb75316f0491ea84e44f66fed55f1b440df5195d7e3a8203f64fcefa19d182f5be87
languageName: node
linkType: hard

"use-memo-one@npm:^1.1.1":
version: 1.1.3
resolution: "use-memo-one@npm:1.1.3"
Expand Down
Loading