Repository navigation
chore(sync): take marfa v0.0.49 - #720
Merged
Merged
Conversation
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Syncs the generated files from marfa v0.0.49, and teaches the sync script the catalog keys added since v0.0.45. The script refused v0.0.49 and changed nothing, because
builtin_catalog.jsonnow carries keys it did not write.Changes
scripts/sync-from-marfa.shwrites a type'spluralas a setting, a field'slabelin a Label column (shown only where a table has one), the members of a list of entries (items_fields) asfield[].memberrows,minimumandmaximumin the Kind column, a status field'sstatus_valueswith their groups, and an edge type'sacyclicandflatflags when true. It validates each the way it validates existing keys, and accepts a subtype's status field without words. The item fieldtrashed_atjoins the State group..github/scripts/sync-from-marfa.test.shpins each new key and each new refusal.openapi.json,src/generated/).src/lib/catalog.test.tsreads the Required column by its header, checksstatusvalues and entry members.status, the Type rules page gives the field keys and the Iconify icon ID rule (lucide:star), and the Entity and Task examples useemailsand a valid status word.Testing
scripts/sync-from-marfa.shran against marfa at tag v0.0.49..github/scripts/sync-from-marfa.test.sh: 654 passed.pnpm test: 709 passed.pnpm build,pnpm build:statusandpnpm types:checkpass.Notes for reviewers
Review depth: normal. The script change is the part to read.
Follow-ups, not done here:
plural, fieldlabel,items_fields,status_values,minimumandmaximum, or the newtypes/*rules.ItemType.icon,TypeIcon), the Items and types overview and the changelog still describe icons as bare Lucide names.email,phoneorplacefields ofcore.entity, or theauthored-byedge type (no longer in the catalog), were not audited.Checklist