[WPB-27953] Make scim error responses comply with RFC7644. - #5439
Open
fisx wants to merge 4 commits into
Open
Conversation
zebot
added
the
ok-to-test
Contributor
Author
This is ruled out by the type signatures on the |
fisx
force-pushed
the
WPB-27953-make-scim-error-responses-comply-with-rfc7644
branch
from
August 12, 2026 11:02
c198abc to
c0b8ea0
Compare
fisx
marked this pull request as ready for review
August 12, 2026 13:15
supersven
requested changes
Aug 12, 2026
|
|
||
| -- This file is part of the Wire Server implementation. | ||
| -- | ||
| -- Copyright (C) 2025 Wire Swiss GmbH <opensource@wire.com> |
Contributor
There was a problem hiding this comment.
Suggested change
| -- Copyright (C) 2025 Wire Swiss GmbH <opensource@wire.com> | |
| -- Copyright (C) 2026 Wire Swiss GmbH <opensource@wire.com> |
| -- RFC 7644 section 3.12 requires that the response body of a SCIM error *is* | ||
| -- the SCIM error object, not a wire-server 'Wai.Error' with the SCIM error | ||
| -- object nested (double-encoded) into its 'message' field. | ||
| it "renders a SCIM error as the bare RFC 7644 error object" $ do |
Contributor
There was a problem hiding this comment.
This test is great to show that the rendering works. But, it would also be good to prove that it is actually used. Either with dedicated integration or effect tests or by adding assertions to existing tests. I would lean to the latter, because that's quicker to do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5434
This changes the error response body schema for most of the SCIM api. The release notes contain a warning about this with instructions how to re-align code. If anybody is impacted by this change, they are in violation of the RFC as we were and should follow the release note instructions.
https://wearezeta.atlassian.net/browse/WPB-27953
Checklist
changelog.d