Skip to content

Document multi-ingress SSO in multi-ingress tutorial - #137

Open
supersven wants to merge 2 commits into
mainfrom
sventennie/multi-ingress-sso
Open

supersven wants to merge 2 commits into
mainfrom
sventennie/multi-ingress-sso

Conversation

@supersven

@supersven supersven commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Ticket: https://wearezeta.atlassian.net/browse/WPB-28532

Change type

  • Documentation change
  • Build pipeline change
  • Submodule update
  • Deployment change

Basic information

  • THIS CHANGE REQUIRES A WIRE-DOCS RELEASE NOW

Testing

  • I ran/applied the changes myself, in a test environment. (I took the values from the galaxy/multi-ingress test environment. However, there may be dragons.)

Tracking

  • I mentioned this PR in Jira, OR I mentioned the Jira ticket in this PR.
  • I mentioned this PR in one of the issues attached to one of our repositories.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The Spar example cannot render without required contacts, and critical cross-IdP security requirements are omitted.

Review effort: Balanced
Findings: 1 High severity · 1 Medium severity · 1 Low severity

Open (3)
What changed in this PR

Extends multi-ingress documentation to support SAML SSO and account pages.

Changes:

  • Documents Spar multi-domain SSO configuration and certificate allowlisting.
  • Adds account-pages configuration and deployment instructions.
  • Updates webapp and ingress examples.
File Description
src/​how-to/​install/​multi-ingress.md Expands multi-ingress setup guidance for SSO, account pages, and federation constraints.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/how-to/install/multi-ingress.md
Comment thread src/how-to/install/multi-ingress.md
Comment thread src/how-to/install/multi-ingress.md

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The Entra URL and SSO eligibility guidance are inaccurate, and the required submodule update is missing.

Review effort: Balanced
Findings: 2 Medium severity · 2 Low severity

Open (4)
Resolved since last review (2)

Comment thread src/how-to/install/multi-ingress.md
Comment thread src/how-to/install/multi-ingress.md Outdated
Comment thread src/how-to/install/multi-ingress.md Outdated
@supersven supersven changed the title Sventennie/multi ingress sso Document multi-ingress SSO in multi-ingress tutorial Sep 29, 2026
The updated submodule contains multi-ingress docs for web-apps.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The missing submodule update leaves a broken reference, and the SSO version and certificate extraction guidance need correction.

Review effort: Balanced
Findings: 1 High severity · 3 Medium severity · 3 Low severity

Open (7)

Comment thread src/how-to/install/multi-ingress.md
Comment thread src/how-to/install/multi-ingress.md
Comment thread src/how-to/install/multi-ingress.md Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread src/how-to/install/multi-ingress.md Outdated
Comment thread src/how-to/install/multi-ingress.md

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The documented version is unavailable and the required wire-server submodule update is missing.

Review effort: Balanced
Findings: None

Resolved since last review (2)
Previously missed (1)

In code that hasn't changed since last review

Low severity Replace semicolon with “otherwise,”

src/​how-to/​install/​multi-ingress.md:259

The semicolon cannot introduce the dependent phrase “as otherwise.” Use “otherwise,” directly so the recommendation reads grammatically.

This issue also appears in the following locations of the same file:

  • line 342
  • line 372

@supersven
supersven marked this pull request as ready for review September 29, 2026 15:55
@supersven
supersven requested review from a team as code owners September 29, 2026 15:55
Add intructions to setup multi-ingress SSO to the tutorial.
@supersven
supersven force-pushed the sventennie/multi-ingress-sso branch from 5cabebc to 6eaa1d9 Compare September 29, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants