Skip to content

feat: Show Crypto Services section (WPB-27920) - #5171

Open
ohassine wants to merge 17 commits into
developfrom
show-crypto-services
Open

feat: Show Crypto Services section (WPB-27920)#5171
ohassine wants to merge 17 commits into
developfrom
show-crypto-services

Conversation

@ohassine

@ohassine ohassine commented Aug 13, 2026

Copy link
Copy Markdown
Member

https://wearezeta.atlassian.net/browse/WPB-27920


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Adds a Crypto Services section to the debug screen showing which security provider serves each cryptographic call site on this device.

Screen_recording_20260813_115048.mp4

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…-info-screen

# Conflicts:
#	app/src/main/kotlin/com/wire/android/di/metro/WireMetroViewModelBindings.kt
#	app/src/main/kotlin/com/wire/android/ui/debug/DebugInfoViewModelFactory.kt
@ohassine
ohassine changed the base branch from develop to security-providers-info-screen August 13, 2026 09:55
@pull-request-size pull-request-size Bot added size/M and removed size/L labels Aug 13, 2026
@ohassine
ohassine requested a review from MohamadJaara August 13, 2026 09:55
Comment thread app/src/main/res/values/strings.xml Outdated

@yamilmedina yamilmedina left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change needed for the naming of the section, overall good to go after we fix that 🚀

}
}
_state.update { current -> current.copy(appPaths = appPathsProvider(), providers = providers) }
val appCryptoServices = withContext(dispatcherProvider.io()) { appCryptoServicesProvider() }

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: I think this might/rarely throw an exception, perhaps catching the error would be nice to fallback to a "not-found" kind of mechanism

…into show-crypto-services

# Conflicts:
#	app/src/main/kotlin/com/wire/android/ui/debug/securityproviders/SecurityProvidersViewModel.kt
@ohassine
ohassine requested a review from yamilmedina August 14, 2026 17:42
Base automatically changed from security-providers-info-screen to develop August 18, 2026 08:10
@pull-request-size pull-request-size Bot added size/L and removed size/M labels Aug 18, 2026
# Conflicts:
#	app/src/main/kotlin/com/wire/android/ui/debug/securityproviders/AppPathsProvider.kt
#	app/src/main/kotlin/com/wire/android/ui/debug/securityproviders/SecurityProvidersScreen.kt
#	app/src/main/kotlin/com/wire/android/ui/debug/securityproviders/SecurityProvidersViewModel.kt
#	app/src/main/res/values/strings.xml
#	kalium
@pull-request-size pull-request-size Bot added size/M and removed size/L labels Aug 18, 2026
@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 73 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.15%. Comparing base (d9a17c7) to head (b5f0052).

Files with missing lines Patch % Lines
...ug/securityproviders/SecurityProvidersViewModel.kt 0.00% 31 Missing ⚠️
...oid/ui/debug/securityproviders/AppPathsProvider.kt 0.00% 11 Missing ⚠️
.../com/wire/android/util/crypto/AppCryptoServices.kt 0.00% 9 Missing ⚠️
...in/com/wire/android/datastore/EncryptionManager.kt 0.00% 8 Missing ⚠️
...m/wire/android/util/crypto/AppCryptoServiceInfo.kt 0.00% 6 Missing ⚠️
...tlin/com/wire/android/feature/e2ei/OAuthUseCase.kt 0.00% 5 Missing ⚠️
...ndroid/ui/debug/securityproviders/LabelledValue.kt 0.00% 3 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5171      +/-   ##
===========================================
- Coverage    52.26%   52.15%   -0.12%     
===========================================
  Files          668      671       +3     
  Lines        23913    23965      +52     
  Branches      3943     3945       +2     
===========================================
  Hits         12499    12499              
- Misses       10253    10305      +52     
  Partials      1161     1161              
Files with missing lines Coverage Δ
...ndroid/ui/debug/securityproviders/LabelledValue.kt 0.00% <0.00%> (ø)
...tlin/com/wire/android/feature/e2ei/OAuthUseCase.kt 0.00% <0.00%> (ø)
...m/wire/android/util/crypto/AppCryptoServiceInfo.kt 0.00% <0.00%> (ø)
...in/com/wire/android/datastore/EncryptionManager.kt 0.00% <0.00%> (ø)
.../com/wire/android/util/crypto/AppCryptoServices.kt 0.00% <0.00%> (ø)
...oid/ui/debug/securityproviders/AppPathsProvider.kt 0.00% <0.00%> (ø)
...ug/securityproviders/SecurityProvidersViewModel.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9a17c7...b5f0052. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Test Results

2 265 tests  ±0   2 265 ✅ ±0   1m 55s ⏱️ ±0s
  250 suites ±0       0 💤 ±0 
  250 files   ±0       0 ❌ ±0 

Results for commit b5f0052. ± Comparison against base commit d9a17c7.

♻️ This comment has been updated with latest results.

# Conflicts:
#	app/src/main/kotlin/com/wire/android/ui/debug/securityproviders/SecurityProvidersViewModel.kt
@github-actions

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants