feat(conversation): add manual MLS migration (WPB-27446) - #5168
feat(conversation): add manual MLS migration (WPB-27446)#5168MohamadJaara wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (72.28%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #5168 +/- ##
===========================================
+ Coverage 52.77% 52.83% +0.06%
===========================================
Files 659 659
Lines 23589 23669 +80
Branches 3881 3904 +23
===========================================
+ Hits 12448 12506 +58
- Misses 9994 10005 +11
- Partials 1147 1158 +11
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Test Results2 249 tests 2 249 ✅ 1m 47s ⏱️ Results for commit dc210c8. |
| ) | ||
| updateState(groupOptionsState.value.copy(isMigratingToMLS = true)) | ||
| viewModelScope.launch { | ||
| when (val result = migrateConversationToMLS(conversationId)) { |
There was a problem hiding this comment.
I tried to follow the calls inside the MigrateConversationToMLSUseCase and it seems like not all of the branches with IO operations are executed in IO dispatcher.
I would recommend switching to IO dispatcher in the use case to call it safely from view model (main thread safety).
https://wearezeta.atlassian.net/browse/WPB-27446
Goal
Add a temporary manual path for testing Proteus/Mixed conversation migration to MLS during the transition phase.
Jira: WPB-27446
Changes