feat(facade): theme_mode forcing + Web Host CDN 1.0.39 (EE2-2265)#65
Merged
Merged
Conversation
… (EE2-2265) - theme_mode requirement (auto|light|dark, default auto) -> wippy.facade:theme_mode; config_handler returns themeMode in /api/public/facade/config (clamped to the enum) - theming_helpers.build_variables_css emits the three-state forcing-aware model for @dark/@light cssVariables (OS media gated against the opposite forced scope, plus a .w-theme-* class rule), so app cssVariables respond to a forced themeMode too - bump fe_facade_url default + Makefile/README/config_handler_test to webcomponents-1.0.39 - re-sync vendored public/@wippy-fe/loading.js from the 1.0.39 CDN EE2-2265
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EE2-2265 — facade theme forcing + CDN 1.0.39
Server-side half of the forced-theme feature (pairs with the Web Host theme switch + app-template
theme_mode).What
theme_moderequirement (auto|light|dark, defaultauto) →wippy.facade:theme_mode.config_handler.luareturnsthemeModein/api/public/facade/config(clamped to the enum — a bad value falls back toautoinstead of shipping a dead class).theming_helpers.build_variables_cssnow emits the three-state forcing-aware model for@dark/@lightcssVariables: OS media query gated against the opposite forced scope (:root:not(.w-theme-*)) plus a.w-theme-*class rule — so appcssVariablesrespond to a forcedthemeMode, not just the OS.fe_facade_urldefault,MakefileWEB_HOST_CDN,README(×3),config_handler_test.