Repository navigation
Correct stream caching, write permissions, and position tracking - #1389
Merged
Merged
Conversation
Closed
Co-authored-by: asika32764 <1639206+asika32764@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix stream issues in PhpInputStream and StringStream
Correct stream caching, write permissions, and position tracking
Nov 7, 2026
asika32764
marked this pull request as ready for review
November 8, 2026 04:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several stream behaviors were inconsistent: the PHP input stream was not cached,
StringStreamignored write restrictions and did not advance after reading its remaining contents, and a null decorator target left its inner stream uninitialized.PhpInputStreaminstance returned bygetInstance().getContents().Stream.