Repository navigation
Load nested language files using dotted keys - #1385
Merged
Merged
Conversation
Co-authored-by: asika32764 <1639206+asika32764@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix loading of nested JSON and YAML language files
Load nested language files using dotted keys
Nov 7, 2026
asika32764
marked this pull request as ready for review
November 8, 2026 03:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nested JSON, PHP, and YAML language fixtures decode to arrays, but the loader passed those arrays to a string-only method. YAML parsing also depends on an optional Symfony package that wasn’t listed in the language package’s suggestions.
symfony/yaml; cover the YAML fixture only when the parser is available.{"windwalker":{"language-test":{"sakura":"Sakura"}}}resolves as: