Skip to content

test: eliminate bootstrap shutdown fixture race#6

Closed
willkill07 wants to merge 1 commit into
wkk_relay-447-codex-bootstrapfrom
wkk_test-bootstrap-shutdown-race
Closed

test: eliminate bootstrap shutdown fixture race#6
willkill07 wants to merge 1 commit into
wkk_relay-447-codex-bootstrapfrom
wkk_test-bootstrap-shutdown-race

Conversation

@willkill07

Copy link
Copy Markdown
Owner

Overview

  • I confirm this contribution is my own work, or I have the right to submit it under this project's license.
  • I searched existing issues and open pull requests, and this does not duplicate existing work.

Details

Close the test fixture's TCP listener before it acknowledges a managed gateway shutdown. This prevents the immediate post-shutdown health check from racing a still-open fake listener on slower runners.

Where should the reviewer start?

crates/cli/tests/coverage/shared/bootstrap_state_tests.rs: the authenticated shutdown fixture now drops its listener before writing the 204 response.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

Signed-off-by: Will Killian <wkillian@nvidia.com>
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 48cc6164-8616-4065-aa49-cfb08bdf71ee

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch wkk_test-bootstrap-shutdown-race

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@willkill07

Copy link
Copy Markdown
Owner Author

Integrated into NVIDIA#395 as ab7cf50; closing this stacked draft.

@willkill07 willkill07 closed this Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant