test: eliminate bootstrap shutdown fixture race#6
Closed
willkill07 wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Will Killian <wkillian@nvidia.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
Integrated into NVIDIA#395 as ab7cf50; closing this stacked draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Details
Close the test fixture's TCP listener before it acknowledges a managed gateway shutdown. This prevents the immediate post-shutdown health check from racing a still-open fake listener on slower runners.
Where should the reviewer start?
crates/cli/tests/coverage/shared/bootstrap_state_tests.rs: the authenticated shutdown fixture now drops its listener before writing the 204 response.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)