mppx validate: multi-challenge support, per-method validation, streaming output#629
Open
bensandler-stripe wants to merge 1 commit into
Open
Conversation
bensandler-stripe
force-pushed
the
bensandler-validate-improvements
branch
from
09fafb7 to
5a9072e
Compare
commit: |
bensandler-stripe
force-pushed
the
bensandler-validate-improvements
branch
2 times, most recently
from
7bec8d5 to
9241fef
Compare
bensandler-stripe
force-pushed
the
bensandler-validate-improvements
branch
from
9241fef to
91e84bf
Compare
Contributor
Author
bensandler-stripe
force-pushed
the
bensandler-validate-improvements
branch
8 times, most recently
from
ea9256f to
ecc5e92
Compare
brendanjryan
left a comment
brendanjryan
left a comment
Collaborator
There was a problem hiding this comment.
@bensandler-stripe -- some CI issues but content-wise this look good!
bensandler-stripe
force-pushed
the
bensandler-validate-improvements
branch
10 times, most recently
from
0eca153 to
e474a0c
Compare
Contributor
Author
|
ah @brendanjryan sorry if I wasted your time, I was adding a few other fixes to this branch. Will get your review in a few. |
bensandler-stripe
force-pushed
the
bensandler-validate-improvements
branch
5 times, most recently
from
b77cf89 to
fb93ddf
Compare
bensandler-stripe
changed the title
bensandler-stripe
force-pushed
the
bensandler-validate-improvements
branch
7 times, most recently
from
65bd823 to
6f5a7dc
Compare
Contributor
Author
|
@brendanjryan let's merge #631 first (this PR is now rebased off that branch) and then I'll have you review this one |
…ment loop - Multi-challenge parsing (fromResponseList) with per-method [tag] prefixes - Per-method field validation for Stripe, EVM, and Tempo - Payment loop tries each supported method with per-method prompts - Common field checks reduced across all challenges - URL resolution fix for subpath-mounted servers - BigInt guards with isValidIntegerAmount - Malformed challenge detection and reporting GIT_VALID_PII_OVERRIDE
bensandler-stripe
force-pushed
the
bensandler-validate-improvements
branch
from
6f5a7dc to
a23b9ca
Compare
| @@ -0,0 +1,5 @@ | |||
| --- | |||
Contributor
Author
There was a problem hiding this comment.
diff is a bit easier to review with hiding whitespace:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of improvements to
mppx validate. Builds on #631.Bug fixes:
mppx validate https://api.example.com/mppnow correctly resolves to/mpp/openapi.jsoninstead of/openapi.json)isValidIntegerAmountregex check first (prevents crash on non-integer amounts like "5.000000")fromResponseListto parse all payment methods fromWWW-Authenticate(previously only picked the first one)UX and validation improvements:
recipientorsplitsDiffs before/after