Fix undefined $subs crash in showAllDirFiles() with flat view + load-… - #246
Merged
Conversation
…all-repos showAllDirFiles() referenced $subs to build the ".." parent-directory entry in flat view, but never received or computed it itself. The variable is only ever assigned in showTreeDir(), on the code path that calls showDirFiles() instead -- showTreeDir() returns early via showAllDirFiles() whenever $config->showLoadAllRepos() is enabled, before $subs is ever set. setLoadAllRepos(true) and useFlatView() are independent, both documented config options, so enabling both together is a legitimate configuration. On PHP 8.0+ (this project's floor), count(null) throws a TypeError instead of the silent PHP 7 warning, so any directory listing deeper than the repository root crashed outright under that combination. Compute $subs locally from $path, the same way showTreeDir() does, instead of relying on a value only ever set on a code path this function is never reached from.
michael-o
force-pushed
the
fix-showAllDirFiles-undefined-subs
branch
from
September 10, 2026 15:48
684aa13 to
539dbcf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…all-repos
showAllDirFiles() referenced $subs to build the ".." parent-directory entry in flat view, but never received or computed it itself. The variable is only ever assigned in showTreeDir(), on the code path that calls showDirFiles() instead -- showTreeDir() returns early via showAllDirFiles() whenever $config->showLoadAllRepos() is enabled, before $subs is ever set.
setLoadAllRepos(true) and useFlatView() are independent, both documented config options, so enabling both together is a legitimate configuration. On PHP 8.0+ (this project's floor), count(null) throws a TypeError instead of the silent PHP 7 warning, so any directory listing deeper than the repository root crashed outright under that combination.
Compute $subs locally from $path, the same way showTreeDir() does, instead of relying on a value only ever set on a code path this function is never reached from.