fix(client): avoid double slash when joining dynamicPublicPath#2348
Open
bjohansebas wants to merge 1 commit into
Open
fix(client): avoid double slash when joining dynamicPublicPath#2348bjohansebas wants to merge 1 commit into
bjohansebas wants to merge 1 commit into
Conversation
When output.publicPath ends with a slash (the common case) and the SSE path starts with one, the naive concatenation produced URLs like `https://host//__webpack_hmr`, which never match the server-side pathname check. Ref webpack/webpack-hot-middleware#366
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## hot-middleware #2348 +/- ##
==================================================
- Coverage 93.57% 93.23% -0.34%
==================================================
Files 4 4
Lines 1182 1182
Branches 354 354
==================================================
- Hits 1106 1102 -4
- Misses 68 72 +4
Partials 8 8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When output.publicPath ends with a slash (the common case) and the SSE path starts with one, the naive concatenation produced URLs like
https://host//__webpack_hmr, which never match the server-side pathname check.Ref webpack/webpack-hot-middleware#366
Summary
What kind of change does this PR introduce?
Did you add tests for your changes?
Does this PR introduce a breaking change?
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Use of AI