Skip to content

chore(deps): replace on-finished with Node.js built-in `stream.finished #2346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bjohansebas wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): replace on-finished with Node.js built-in `stream.finished #2346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/plenty-pans-clap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"webpack-dev-middleware": patch
---

Replace the `on-finished` dependency with Node.js built-in `stream.finished`.
14 changes: 2 additions & 12 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
"dependencies": {
"memfs": "^4.56.10",
"mime-types": "^3.0.2",
"on-finished": "^2.4.1",
"range-parser": "^1.2.1",
"schema-utils": "^4.3.3"
},
Expand All @@ -65,7 +64,6 @@
"@types/express": "^5.0.2",
"@types/mime-types": "^3.0.1",
"@types/node": "^22.3.0",
"@types/on-finished": "^2.3.4",
"babel-jest": "^30.1.2",
"connect": "^3.7.0",
"cspell": "^10.0.0",
Expand Down
4 changes: 2 additions & 2 deletions src/middleware.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
const path = require("node:path");
const querystring = require("node:querystring");
const { finished } = require("node:stream");

const mime = require("mime-types");
const onFinishedStream = require("on-finished");

const {
createReadStreamOrReadFile,
Expand Down Expand Up @@ -1122,7 +1122,7 @@ function wrapper(context) {

if (outgoing) {
// Response finished, cleanup
onFinishedStream(outgoing, (err) => {
finished(outgoing, (err) => {
if (err) {
context.logger.error("Stream error:", err);
}
Expand Down
Loading