Repository navigation
fix: answer without an import graph where TypeScript is the native 7 - #384
Closed
alexander-akait wants to merge 2 commits into
Closed
alexander-akait wants to merge 2 commits into
alexander-akait wants to merge 2 commits into
Conversation
TypeScript 7's package is a native compiler and exports only its version. Loaded as the project's TypeScript, it made a graph whose first read threw: a rebuild of oxlint or Biome swallowed it and linted every file, and typed ESLint's signatures failed the check with "Cannot read properties of undefined (reading 'readFile')". The graph is now made only from a TypeScript with `preProcessFile`, `resolveModuleName` and `sys`; anything else is answered as one that cannot be loaded, which every caller already falls back from. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01App18sYbe6Vf6HDCjCXbvf
One or more co-authors of this pull request were not found. You must specify co-authors in commit message trailer via: Supported
Alternatively, if the co-author should not be included, remove the Please update your commit message(s) by doing |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 15 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 19 19
Lines 5570 5630 +60
=======================================
+ Hits 5550 5610 +60
Misses 20 20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01App18sYbe6Vf6HDCjCXbvf
Member
Author
|
EasyCLA fails because the commits carry a Generated by Claude Code |
alexander-akait
added a commit
that referenced
this pull request
Oct 29, 2026
…red TypeScript runs (#392) * perf: watch rebuilds, TypeScript 7, and shared or stopped TypeScript runs One change in place of #371, #384, #387, #389, #390 and #391. Core: - One place keeps what lives as long as a compiler (src/compiler-state.js): keptFor() for state kept per compiler (results, detached reports, the import graph, the TypeScript program), and acquire()/release() for the workers and processes compilers share, started once per key and stopped when the last compiler using them shuts down or closes its watch. The TypeScript check's worker and TypeScript 7's process both go through it, in place of a lifecycle of their own each. - lintDependentsAfterBuild (opt-in): a watch rebuild of a check that reads across files lints only what webpack rebuilt, and what the change reaches after the build. - A check can stop a run of an older compilation nothing will report (cancel()); one another compiler joined is never stopped. - Biome and oxlint are handed every file at once rather than in batches. TypeScript: - TypeScript 7 runs through the API it ships, in a process of its own kept open while webpack watches; the import graph answers without a graph there. - A stale run stops between files; compilers checking the same project alike share one worker and one program. Nothing is listed by hand where the tool can say it: assets and the scripts a config file picks up are told apart by the extensions TypeScript reads, the fallback resolution mode and the error category come from the loaded TypeScript, and each run carries its own stop flag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01App18sYbe6Vf6HDCjCXbvf * test: cover the TypeScript 7 check's error paths rather than ignore them The line under a diagnostic is printed from the text the native compiler checked (Program.getSourceFile) rather than read from disk again, and a file gone since webpack saw it is told by statSync without throwing, so neither needs a catch. A project with no tsconfig.json above it is now tested from a directory outside this repository. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01App18sYbe6Vf6HDCjCXbvf * fix: match the files webpack saw change against the native compiler's on Windows webpack names a changed file with the platform's separators, the native compiler with forward slashes, and Windows tells no case apart, so both are now compared by the same key. The cancel test accepts a run already stopped by the time it looks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01App18sYbe6Vf6HDCjCXbvf * fix: take turns on a shared TypeScript 7 process, and forget a stopped run Compilers checking the same project share the native compiler's process, and a run replaces the snapshot and disposes of the last one, which a run for another compiler could still be reading: runs on one process now take turns. A run stopped for a newer compilation found nothing, so it is no longer kept as what a rebuild the program does not see is answered with. A directory no config file covers is now tested in the import graph. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01App18sYbe6Vf6HDCjCXbvf * refactor: check TypeScript 7 through its 7.1 API, and drop what did not pay off TypeScript 7.1 ships its API as typescript/async, makes snapshots with createSnapshot and snapshot.update, and formats diagnostics itself. The native check now uses that API, found by what the package exports rather than by its version, and TypeScript's own formatter in place of one written here. TypeScript 7.0's API was an unstable preview with none of these calls; a TypeScript offering no API to check with now says so. Measured again on this branch, two additions did not earn their place: - lintDependentsAfterBuild finished the build sooner but printed an error it found in an importer no sooner (1.96-2.64 s against 2.09-2.21 s without it), at the cost of an option and a second report. - cancel() on the checker API only ever served a TypeScript 6 check on a worker reporting as advisory, and TypeScript 7 does not use it. Both are removed, with what they needed: a stop flag per worker run, bookkeeping of which runs another compiler joined, and their tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01App18sYbe6Vf6HDCjCXbvf * fix: watch the config files a TypeScript 7 project extends, and let a run finish before closing The native check reported only the root config file to the watcher, so an edit to a config file it extends, outside the folder watched, went unnoticed unless webpack's own tsconfig resolution happened to watch it. It now reports every config file the program names (getConfigFileNames), and tells the compiler of a change to one as a change rather than a new file. Closing the native process now waits for a run still going. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01App18sYbe6Vf6HDCjCXbvf --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the performance series (#376–#383).
Problem
The import graph (
src/import-graph.js) loads the project's owntypescript. TypeScript 7's package is the native compiler, and its JavaScript entry exports only{ version, versionMajorMinor }.getGraphbuilt a graph on it anyway, and the first read throughts.sys/preProcessFilethrew:affectedFilesthrew, the plugin swallowed it, and every rebuild silently linted every file.signatures()(perf: keep typed-lint results between runs against what each file imports #375) is not wrapped, so the check failed outright:That's what the current
mainreports for a project whosenode_modules/typescriptis a TypeScript-7-shaped module.Change
getGraphonly builds a graph from a TypeScript that haspreProcessFile,resolveModuleNameandsys. Anything else is answered as a TypeScript that couldn't be loaded, which every caller already handles:Keeping the pruning on TypeScript 7 would need an import scanner that doesn't depend on TypeScript. That's a separate, larger change, alongside running the TypeScript check on tsgo.
Measured
The project above, with the ESLint check under typed linting:
main[eslint] Cannot read properties of undefined (reading 'readFile')Tests
typescriptexports only a version gets no graph. With the guard disabled, the test fails.eslint,tsc, prettier, cspell andlint:schemaare clean.readsAcrossFiles) and a changeset are updated.Generated by Claude Code