Repository navigation
Link third-party deps into the reload-stress fixture - #1602
Merged
Merged
Conversation
#1600 made the fixture copy the framework packages instead of linking them, but the copies lost their hoisted dependencies, so on Bun the server could not load amaro (Bun has no built-in TS stripper) and the dev server never came up. The Bun matrix failed on every PR since. The fixture now links the repo's third-party packages beside the copies, as a real install would place them; only framework packages stay copied. Claude-Session: https://claude.ai/code/session_01SZ72LSPAo4NvYvBDSD6RLo
|
Preview for Next: fix the listed keys in the compose file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #1600, the Bun matrix fails on every PR:
test/bun/dev-reload-stress.test.mjsreports "dev server never came up". The fixture now copies the framework packages, and the copies lost their hoisted dependencies, so Bun could not loadamaro, the TypeScript stripper it needs. The fixture now links the repo's third-party packages beside the copies. Verified on bun 1.3.14, bun 1.4.2 and Node.https://claude.ai/code/session_01SZ72LSPAo4NvYvBDSD6RLo