Repository navigation
fix: settle an in-place dev reload in 300ms instead of 2s - #1586
Merged
Merged
Conversation
The browser relay held every reload for a 2s quiet window so a burst would not reload into a Node server about to be restarted. Bun's dev server now applies edits in place, so that wait was most of the save-to-paint time (3.8s measured in a hosted preview). Frames from a server that reloads in place say so, and a batch made only of those settles after 300ms; any restart signal keeps the 2s window and the 5s cap is unchanged. Refs #1575 Claude-Session: https://claude.ai/code/session_01SZ72LSPAo4NvYvBDSD6RLo
|
Preview for Next: fix the listed keys in the compose file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1584 (refs #1575). A server that applies edits in place (Bun's one long-lived dev server,
--no-hot) marks its reload framesinPlace; the relay settles a batch of only those after 300ms instead of 2000ms. A batch with any restart signal keeps 2000ms; the 5s cap is unchanged. Tests: relay browser suite (Chromium/Firefox/WebKit), SseHub unit,bun test/bun/dev-morph-verdict.mjs,bun test/bun/dev-reload-stress.mjs.https://claude.ai/code/session_01SZ72LSPAo4NvYvBDSD6RLo