Skip to content

fix(#3165): OSC 8 hyperlinks not opening in the terminal #3384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nino-robotfutures-co wants to merge 1 commit into
base: main
Choose a base branch
from
+27 −27
Open

fix(#3165): OSC 8 hyperlinks not opening in the terminal #3384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 27 additions & 27 deletions frontend/app/view/term/termwrap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,29 @@ export class TermWrap {
this.lastCommandAtom = jotai.atom(null) as jotai.PrimitiveAtom<string | null>;
this.claudeCodeActiveAtom = jotai.atom(false);
this.webglEnabledAtom = jotai.atom(false) as jotai.PrimitiveAtom<boolean>;
const activateLink = (e: MouseEvent, uri: string) => {
e.preventDefault();
const modifierPressed = PLATFORM === PlatformMacOS ? e.metaKey : e.ctrlKey;
if (!modifierPressed) {
return;
}
fireAndForget(() => openLink(uri));
};
const linkHover = (e: MouseEvent, uri: string) => {
this.hoveredLinkUri = uri;
this.onLinkHover?.(uri, e.clientX, e.clientY);
};
const linkLeave = () => {
this.hoveredLinkUri = null;
this.onLinkHover?.(null, 0, 0);
};
// OSC 8 hyperlinks don't go through the WebLinksAddon; without a linkHandler they fall back to
// xterm's default window.open() handler, which Electron's window-open handler silently blocks.
options.linkHandler = {
activate: (e, uri) => activateLink(e, uri),
hover: (e, uri) => linkHover(e, uri),
leave: () => linkLeave(),
};
this.terminal = new Terminal(options);
this.fitAddon = new FitAddon();
this.serializeAddon = new SerializeAddon();
Expand All @@ -151,33 +174,10 @@ export class TermWrap {
this.terminal.loadAddon(this.fitAddon);
this.terminal.loadAddon(this.serializeAddon);
this.terminal.loadAddon(
new WebLinksAddon(
(e, uri) => {
e.preventDefault();
switch (PLATFORM) {
case PlatformMacOS:
if (e.metaKey) {
fireAndForget(() => openLink(uri));
}
break;
default:
if (e.ctrlKey) {
fireAndForget(() => openLink(uri));
}
break;
}
},
{
hover: (e, uri) => {
this.hoveredLinkUri = uri;
this.onLinkHover?.(uri, e.clientX, e.clientY);
},
leave: () => {
this.hoveredLinkUri = null;
this.onLinkHover?.(null, 0, 0);
},
}
)
new WebLinksAddon(activateLink, {
hover: linkHover,
leave: linkLeave,
})
);
this.setTermRenderer(WebGLSupported && waveOptions.useWebGl ? "webgl" : "dom");
// Register OSC handlers
Expand Down