Skip to content

Guard IAP brand and client against destructive replaces #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phosphore merged 1 commit into from
Jul 7, 2026
Merged

Guard IAP brand and client against destructive replaces #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions terraform/jitgroups-appengine/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,10 +260,13 @@ resource "google_iap_brand" "iap_brand" {
project = var.project_id
support_email = var.admin_email
application_title = "JIT Groups"
# lifecycle {
# # This resource can't be deleted.
# prevent_destroy = true
# }
lifecycle {
# Brands cannot be deleted or recreated (one per project, and the
# IAP OAuth Admin API is deprecated). A support_email change forces
# replacement, which first deletes the dependent IAP client and
# breaks all logins (2026-07-07 outage). Fail the plan instead.
prevent_destroy = true
}
}

#
Expand All @@ -272,6 +275,12 @@ resource "google_iap_brand" "iap_brand" {
resource "google_iap_client" "iap_client" {
display_name = "JIT Groups"
brand = google_iap_brand.iap_brand.name

# Never delete the live OAuth client through the API: App Engine IAP
# keeps referencing it and every login fails with `deleted_client`
# (2026-07-07 outage). On destroy/replace, only remove it from state
# and leave the client running in GCP.
deletion_policy = "ABANDON"
}

#
Expand Down
Loading