Repository navigation
Conversation
kreneskyp
marked this pull request as ready for review
October 14, 2026 20:04
Member
|
wtf is "IR-786" |
Member
|
From other PRs by account this appears to be fully-automated AI submissions. Come back with a human touch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of IR-786.
This partial contribution exposes a safe Windows
JobObjectCPU-time query through the standard-processChildWrapperAPI. It reports cumulative user plus kernel time from Job Object accounting, including members that exited before the sample. The Windows integration test exercises a descendant that burns CPU and exits before the parent is sampled.The resident-memory method fails closed with
Unsupported. Windows exposes per-process working-set snapshots, but not a coherent current resident-memory aggregate for a Job Object. This change does not satisfy the resident-memory criterion or complete IR-786.Checks on macOS:
cargo fmt --all -- --checkpassed.cargo check --tests --target x86_64-pc-windows-msvc --no-default-features --features std,job-objectpassed (compile only; no Windows tests executed).std; no Clippy pass is claimed.cargo test --locked --features std --all-targetspassed (55 tests; Windows-only tests were not executed on macOS).cargo metadata --no-deps --all-featuresreports no installable binary targets;cargo package --listdoes not include a helper binary source.Native Windows execution and upstream CI remain unverified. This branch is based on
main; it may need a rebase after the open kill-on-close PR #64, which touchessrc/std/job_object.rs.