Fix warp_tui compile error: thread RequestTeamScope through TUI voice transcription - #15570
Merged
Merged
Conversation
PR #15554 added a team_scope: RequestTeamScope parameter to Transcriber::transcribe, updating the GUI call site (EditorView::handle_voice_session_result) but missing the TUI call site in TuiVoiceInputModel::handle_session_result. This broke every TUI release build (voice_input is only compiled by the release workflow's --features voice_input, which presubmit does not exercise). Derive the scope the same way the GUI does, via UserWorkspaces::team_context_resolver, captured from the owning TuiInputView's ViewContext at construction time (before the transcription future is spawned off the main thread) and threaded into TuiVoiceInputModel, which only has a ModelContext at the point it needs the scope.
Contributor
Author
|
This PR was generated with Warp. Comment |
MaggieShan
marked this pull request as ready for review
August 26, 2026 15:37
IsaiahWitzke
approved these changes
Aug 26, 2026
MaggieShan
enabled auto-merge (squash)
August 26, 2026 15:40
1 task
auto-merge was automatically disabled
August 26, 2026 17:18
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Fixes a compile error breaking every TUI release build (dev/preview/stable, all archs) in the scheduled
Cut New Releasesworkflow.PR #15554 ("Scope /ai/transcribe to the window's team") added a third
team_scope: RequestTeamScopeparameter toTranscriber::transcribeand updated the GUI call site (EditorView::handle_voice_session_result), but missed the TUI call site inTuiVoiceInputModel::handle_session_result(crates/warp_tui/src/voice_input.rs). That module is compiled only when thevoice_inputfeature is enabled — which only the TUI release build does — so the mismatch escaped bothwarp's andwarp_tui's normal CI.This PR threads a
RequestTeamScopeinto the TUI call site the same way the GUI does:UserWorkspaces::team_context_resolveris captured from the owningTuiInputView'sViewContextat construction time (when a window is still reachable) and stored onTuiVoiceInputModel, which only has aModelContextby the time it needs to resolve the scope and spawn the transcription future off the main thread.Linked Issue
No tracked issue — this is a release-blocking build break reported directly from a failing GitHub Actions run in
warp-internal.Testing
cargo check -p warp_tui --bin warp-tui-oss --features release_bundle,standalone,voice_input— passes. This mirrors the exact feature setscript/macos/bundle(and the Linux/Windows equivalents) use to build the TUI release artifact.cargo clippy -p warp_tui --bin warp-tui-oss --features release_bundle,standalone,voice_input -- -D warnings— passes../script/format— no changes needed.crates/warp_tui/src/voice_input_tests.rswere updated for the newTuiVoiceInputModel::newparameter (usingUserWorkspaces::teamless_context_resolver_for_test(), matching the existing pattern intest_fixtures.rs). I could not runcargo test -p warp_tui --features voice_input,test-utilin this sandbox: that path enableswarpui_core/test-util(viawarp/test-util→warp_terminal/test-util) withoutwarpui's own, separately-declaredtest-utilfeature, which is what actually gates theDelegateimpl blocks that provideget_cursor_shape()incrates/warpui. That feature-wiring mismatch betweenwarpui_coreandwarpui(not a missing implementation, and not platform-specific — the macOS impl is gated the same way) makes the build fail withE0046(not all trait items implemented: get_cursor_shape). I confirmed this reproduces identically on unmodifiedmasterwith the same feature flags, so it isn't caused by this change — flagging it since it also blocks running these tests in CI'stest-utilpaths. (Filed a fuller writeup of this in Cover warp_tui's opt-in features (voice_input, etc.) in presubmit and CI clippy #15575, a presubmit/CI-coverage follow-up.)Presubmit coverage gap:
script/presubmitrunscargo clippy --workspace --exclude warp_completer --all-targets --testsandcargo clippy -p warp --all-targets --tests, neither with--all-features(explicitly disabled via aTODOcomment) nor--features voice_input. Sincevoice_inputis an opt-in, non-default feature onwarp_tui, presubmit never compilesvoice_input.rs. That's exactly how a green PR broke every TUI release build. Not fixed here per scope; filed as #15575../script/run(not applicable — headless TUI compile fix, nowarp-server/device available to exercise a live transcription request in this environment)Agent Mode